Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sslyze 2.1.4 #45750

Closed
wants to merge 6 commits into from
Closed

sslyze 2.1.4 #45750

wants to merge 6 commits into from

Conversation

Gillingham
Copy link

@Gillingham Gillingham commented Oct 23, 2019 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@chenrui333
Copy link
Member

20:05:07 copying build/lib.macosx-10.14-x86_64-3.7/nassl/_nassl.cpython-37m-darwin.so -> nassl
20:05:07 Error: An exception occurred within a child process:
20:05:07 NameError: undefined local variable or method `nassl_path' for #Formulary::FormulaNamespace098ec6c15fc5e5e9932692d8bd47a06e::Sslyze:0x00007feb4a120808
20:05:07

@chenrui333 chenrui333 added the build failure CI fails while building the software label Oct 24, 2019
Gillingham added 2 commits October 23, 2019 17:45
Restore erroneously removed variable declaration then rerun
55cdc8c 
```
brew uninstall --force sslyze
brew install --build-from-source Formula/sslyze.rb
brew test Formula/sslyze.rb
brew audit --strict Formula/sslyze.rb
```
Move libffi to a regular dep instead just builddep
2d0e754
@chenrui333 chenrui333 removed the build failure CI fails while building the software label Oct 24, 2019
@chenrui333
Copy link
Member

@Gillingham Thanks for making efforts to get the PR build passed, can you squash the commits into one single commit (commit msg format as sslyze 2.1.4)?

@Gillingham Gillingham changed the title sslyze: 2.1.4 sslyze 2.1.4 Oct 24, 2019
Gillingham added 2 commits October 24, 2019 08:27
sslyze 2.1.4
fbfded1 
Fix audit complaints

Restore erroneously removed variable declaration then rerun
```
brew uninstall --force sslyze
brew install --build-from-source Formula/sslyze.rb
brew test Formula/sslyze.rb
brew audit --strict Formula/sslyze.rb
```

Move libffi to a regular dep instead just builddep
Merge branch 'master' of github.com:Gillingham/homebrew-core
4196316
@Gillingham
Copy link
Author

No idea if I squashed that correctly with the merge that it prompted me to do immediately following.

@fxcoudert fxcoudert mentioned this pull request Nov 22, 2019
Closed
62 tasks
@Bo98
Copy link
Member

Bo98 commented Nov 23, 2019

Thanks for this. Apologies for the wait. We're currently building Python 3.8 (see #45337) and we'll revisit this pull request once that's finished.

@Bo98 Bo98 added do not merge python Python use is a significant feature of the PR or issue labels Nov 23, 2019
@michaelblyons michaelblyons mentioned this pull request Dec 10, 2019
Closed
This was referenced Dec 17, 2019
Closed
Closed
@iMichka
Copy link
Member

iMichka commented Dec 18, 2019

Superseded by #47993. We needed to make the update to Python 3 quickly and could not wait, as the pyhton@2 formula will be removed at the end of the year. Sorry for this PR but we had to act quick.

@iMichka iMichka closed this Dec 18, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gillingham @chenrui333 @Bo98 @iMichka